[riot-notifications] [RIOT-OS/RIOT] Fix return value of aes_init for keys of incorrect length (#10271)

Juan I Carrano notifications at github.com
Mon Mar 11 13:10:04 CET 2019


@bergzand , what's the veredict on this. I think it is a desirable behaviour that invalid parameters fail as early as possible, during initialization. On the other hand, it is true that there may be code that is not checking the error. The documentation, however, made it clear that this could happen:

https://github.com/RIOT-OS/RIOT/blob/66e0d4803773f7a60d8d17f42d089eadab5ff2e0/sys/include/crypto/ciphers.h#L127-L133

In conclusion, I'm _for_ this change.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10271#issuecomment-471513924
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/f9d0a8b3/attachment.html>


More information about the notifications mailing list