[riot-notifications] [RIOT-OS/RIOT] nrf52: use cortexm.ld script when applicable (#11127)

Ga√ętan Harter notifications at github.com
Mon Mar 11 16:45:31 CET 2019


I tested for the `nrf52dk` and the resulting binary is the same by comparing to the `master` (origin) commit:

```
 RIOT_CI_BUILD=1 BOARD=nrf52dk make all clean-intermediates; mv bin bin_master
```

```
sha1sum bin_master/nrf52dk/* bin_pr/nrf52dk/* | sort
403673ef4e0e21f307387297f38afce4b8a94207  bin_pr/nrf52dk/hello-world.elf
4f3119f27fe3b694a3618effe55d48f1967b71dc  bin_master/nrf52dk/hello-world.elf
73f21fd1f29af794a440c0cc4656215cd606ca6f  bin_master/nrf52dk/hello-world.bin
73f21fd1f29af794a440c0cc4656215cd606ca6f  bin_pr/nrf52dk/hello-world.bin
792c2c40097879103ec2cdcf6f382fa777d1c5a2  bin_master/nrf52dk/hello-world.map
adcf866733ccbe766209576636dca491508183a5  bin_pr/nrf52dk/hello-world.map

diff -r bin_master/ bin_pr/                                                                                                                                                                                                                                                           
Binary files bin_master/nrf52dk/hello-world.elf and bin_pr/nrf52dk/hello-world.elf differ                                                                                                                                                                                                 
diff -r bin_master/nrf52dk/hello-world.map bin_pr/nrf52dk/hello-world.map
2605a2606,2609
>                 0x0000000000000000                _rom_start_addr = 0x0
>                 0x0000000020000000                _ram_start_addr = 0x20000000
>                 0x0000000000080000                _rom_length = 0x80000
>                 0x0000000000010000                _ram_length = 0x10000
2616,2618c2620,2622
<                 0x0000000000080000                rom_length = 0x80000
<                 0x0000000000000000                boot_offset = DEFINED (offset)?offset:0x0
<                 [0x0000000000080000]                rom_length = DEFINED (length)?length:rom_length
---
>                 0x0000000000000000                _rom_offset = DEFINED (_rom_offset)?_rom_offset:0x0
>                 0x0000000000080000                _fw_rom_length = DEFINED (_fw_rom_length)?_fw_rom_length:(_rom_length - _rom_offset)
>                 0x0000000000000001                ASSERT ((_fw_rom_length <= (_rom_length - _rom_offset)), Specified firmware size does not fit in ROM)
```

Are there other things that need to be checked ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11127#issuecomment-471596611
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/2be9e19e/attachment.html>


More information about the notifications mailing list