[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Mon Mar 11 16:46:15 CET 2019


OK. I'd say IRQ for the Mega2560 needs to be fixed regardless of this PR. As this PR only adds to the compiled binary if the corresponding module is manually added, there is no risk of breaking stuff. (Worst thing that could happen is that the new feature does not work for the `jiminy-mega256rfr2` and the `waspmote-pro`.)

Two things I'd like to see:
1. Splitting the commit into two: One for the feature, one for the test
2. Adding some documentation. (I'd say put it once in `boards/common/atmega/doc.txt`, instead of copy pasting it into every board. But I'd put a link to that page in every ATmega board so that people actually end up reading the doc.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#issuecomment-471596932
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/d12d5c87/attachment-0001.html>


More information about the notifications mailing list