[riot-notifications] [RIOT-OS/RIOT] nrf52: use cortexm.ld script when applicable (#11127)

Gaƫtan Harter notifications at github.com
Mon Mar 11 17:11:29 CET 2019


cladmi requested changes on this pull request.



> @@ -24,6 +24,8 @@ ifeq (jlink,$(PROGRAMMER))
     export JLINK_PRE_FLASH := erase\nloadfile $(BINDIR)/softdevice.hex
     export FLASH_ADDR := 0x1f000
     export LINKER_SCRIPT ?= $(RIOTCPU)/$(CPU)/ldscripts/$(CPU_MODEL)_sd.ld
+  else
+    LINKER_SCRIPT ?= cortexm.ld

I would rather define `LINKER_SCRIPT ?= cortexm.ld` after the `PROGRAMMER` section. It is not really programmer specific.
This way, it would always be defined to this if not set differently for `nordic_softdevice_ble`.

It would also make `nrf52840-mdk` work as currently the programmer is a different one and adding `LINKER_SCRIPT ?= cortexm.ld` in the board feels out of place in the `pyocd` section.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11127#pullrequestreview-212933910
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/7d14764c/attachment.html>


More information about the notifications mailing list