[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Mon Mar 11 17:37:51 CET 2019


maribu commented on this pull request.

I may have found the Murdock issue

> @@ -1 +1,4 @@
 INCLUDES += -I$(RIOTBOARD)/common/atmega/include
+
+# require Makefile.dep for correct dependency management of atmega PCINTs
+include $(RIOTCPU)/$(CPU)/Makefile.dep

This file is already included via `boards/common/atmega/Makefile.dep`

> @@ -0,0 +1 @@
+-include $(RIOTCPU)/atmega_common/Makefile.dep

This could be `include` instead of `-include`

> @@ -1 +1,4 @@
 INCLUDES += -I$(RIOTBOARD)/common/atmega/include
+
+# require Makefile.dep for correct dependency management of atmega PCINTs
+include $(RIOTCPU)/$(CPU)/Makefile.dep

I thin this is the issue with Murdock. I believe the CPU variable is not yet available here. Also: `boards/common/atmega/Makefile.dep` already contains this exact include, so no need to include it twice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#pullrequestreview-212947081
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/43846c82/attachment.html>


More information about the notifications mailing list