[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Mon Mar 11 19:21:32 CET 2019


maribu commented on this pull request.

Found one more issue in the Makefiles, but still this is not the one causing Murdock to give up

> @@ -0,0 +1,24 @@
+# expand atmega_pcint module
+ifneq (,$(filter atmega_pcint,$(USEMODULE)))
+    USEMODULE += atmega_pcint0 atmega_pcint1 atmega_pcint2

With only `atmega_pcint0` and `atmega_pcint1` now being supported on all AVRs, this needs to be adapted. Also: The indent here needs to be two spaces, instead of four. (The Makefiles have a different code style than the C files.)

How about this:

```C
ifneq (,$(filter atmega_pcint,$(USEMODULE)))
  USEMODULE += atmega_pcint0 atmega_pcint1
  ifneq (,$(filter atmega_pcint2,$(FEATURES_PROVIDED)))
    USEMODULE += atmega_pcint2
  endif
  ifneq (,$(filter atmega_pcint3,$(FEATURES_PROVIDED)))
    USEMODULE += atmega_pcint2
  endif
endif
```

But that will only work if the features are already in place when this is evaluated. But as the common Makefile is included from the CPU specific ones, this should be true.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#pullrequestreview-213006322
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/b3ddce98/attachment.html>


More information about the notifications mailing list