[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Mon Mar 11 22:03:53 CET 2019


@kaspar030, @kYc0o, @ZetaR60: This feature has been quite controversial in an earlier PR. Thus, I'd like to have a second ACK before merging. In the last PR there were two major points of critique:

1. Conflicts with the implementation of context switches back then, as the code at that point in time used PCINT0 interrupt for context switches. In the meantime (and for unrelated reasons) the context switch code was changed to no longer use PCINT0 for that. So this point no longer applies
2. Increase in RAM and ROM

With this PR using a pseudo module, RAM and ROM requirements are not increased unless someone explicitly unlocks this feature. I also believe that there is little room for improvement regarding RAM and ROM size - at least not without using arcane magic like carefully crafted inline assembly.

Btw: It is very nice that this PR allows to use the hardware independent API `gpio_init_int()` and completely shields the application programmer from the weird shared interrupt vectors using here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#issuecomment-471729008
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190311/fade3eee/attachment.html>


More information about the notifications mailing list