[riot-notifications] [RIOT-OS/RIOT] murdock: improve error message should "info-boards-supported" fail (#11160)

Sebastian Meiling notifications at github.com
Tue Mar 12 14:49:41 CET 2019


smlng commented on this pull request.



> @@ -137,7 +147,12 @@ compile() {
     local board=$(echo $2 | cut -f 1 -d':')
     local toolchain=$(echo $2 | cut -f 2 -d':')
 
-    [ "$board" = "makefile_broken" ] && error "$0: Makefile in \"$appdir\" seems to be broken!"
+    [ "$board" = "makefile_broken" ] && {
+        echo "$0: There seems to be a problem in \"$appdir\" while getting supported boards!"
+        echo "$0: testing \"make -C$appdir make-info-boards-supported\"..."
+        make -C$appdir make-info-boards-supported && echo "$0: success. no idea what's wrong." || echo "$0: failed!"

is this right? I cannot find a target `make-info-boards-supported` just `info-boards-supported`:

```
git grep make-info-boards-supported

```

but 
```
git grep info-boards-supported
.murdock:    local boards="$(make --no-print-directory -C$appdir info-boards-supported 2>/dev/null || echo broken)"
Makefile.include:GLOBAL_GOALS += buildtest info-boards-supported info-boards-features-missing info-buildsizes info-buildsizes-diff
dist/tools/compile_and_test_for_board/compile_and_test_for_board.py:        cmd = ['info-boards-supported']
makefiles/info-global.inc.mk:info-boards-supported:
makefiles/info.inc.mk:.PHONY: info-objsize info-buildsizes info-build info-boards-supported \
makefiles/info.inc.mk:  @echo $$($(MAKE) info-boards-supported)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11160#pullrequestreview-213399233
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190312/c3dfb2e4/attachment.html>


More information about the notifications mailing list