[riot-notifications] [RIOT-OS/RIOT] cpu/stm32_common: remove WKUP2 pin enable (#11167)
notifications at github.com
Tue Mar 12 16:43:16 CET 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
Currently StandBy mode is unusable for nucleo l0 boards. When looking at the datasheet:
> WKUP pin 2 is used for wakeup from Standby mode and forced in input pull down
configuration (rising edge on WKUP pin 2 wakes-up the system from Standby mode).
But when looking at the boards schematic PC13 (wake-up pin 2), is also the user button which is connected to VDD, this means that unless user is holding the user button pressed all the time, a rising edge is triggered immediately. More so, it leaves the MCU in a weird state after reset.
Not enabling wake up pin 2 when entering StandBy fixes the issue.
### Testing procedure
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
On nucleo boards that support LPM run:
`make BOARD=nucleo-l073rz -C tests/periph_pm/ PORT=/dev/ttyACM0 clean flash`
`unblock_rtc 1 3`
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* cpu/stm32_common: remove WKUP2 pin enable
-- File Changes --
M cpu/stm32_common/periph/pm.c (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications