[riot-notifications] [RIOT-OS/RIOT] Makefile.include: RIOTNOLINK ensure linking fails (#11168)

Juan I Carrano notifications at github.com
Wed Mar 13 15:23:32 CET 2019


jcarrano commented on this pull request.



>  endif # RIOTNOLINK
 
 $(ELFFILE): $(BASELIBS)
 	$(Q)$(_LINK) -o $@
 
+# Try to link and ensure it fails
+$(ELFFILE).nolink: FORCE
+$(ELFFILE).nolink: $(BASELIBS)
+	$(Q)\
+	  $(_LINK) -o $(ELFFILE) 2>&1 > $@; \

```suggestion
	  $(_LINK) -o /dev/null 2>&1 > $@; \
```
This way we don't have to worry about cleanup if linking succeeds.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11168#pullrequestreview-213979309
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190313/5d5f0e03/attachment.html>


More information about the notifications mailing list