[riot-notifications] [RIOT-OS/RIOT] cpu/stm32f0: add periph_pm support (#9521)

Francisco notifications at github.com
Wed Mar 13 17:11:20 CET 2019


fjmolinas commented on this pull request.



>  #endif
+            PWR->CSR |= _ewup_config();

I don't think activating all wake-up pins available by default is a good choice. On nucleo boards WKUP2 is connected to user button and VDD which triggers wakeup from STANDBY mode immediately (except for stm32l433rc) (#11167). On other nucleo boards you have wkup pins connected to other peripherals which can also trigger weird resets.

>  #endif
+            PWR->CSR |= _ewup_config();

Maybe it would be better if this was handled or at least over-writable for every board. Since wiring is very board specific enabling this for all boards using this cpu is prone to conflicts (in some stml4 base boards uart is connected to a wake-up pin too.) IMO default configuration should be no wkup-pin enabled (cpu can allways wake up from RTC), and then when enabling a wkup pin makes sense, this should be handled on board configuration files. Thoughts @aabadie  @vincent-d @kaspar030 ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9521#pullrequestreview-213875580
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190313/c8b21863/attachment.html>


More information about the notifications mailing list