[riot-notifications] [RIOT-OS/RIOT] drivers/sx127x: add gpio pull config define for DIO pins (#11132)

Leandro Lanzieri notifications at github.com
Thu Mar 14 14:04:20 CET 2019


leandrolanzieri approved this pull request.

I was only able to reproduce the error while using the DRF1272F module.
I tested this on sensebox (which already has an external PD), lobaro-lorabox, nucleo + sx1272mb2xas shield and nucleo + DRF1272F module, and everything works. The change makes sense and the option can still be overridden by defining `SX127X_DIO_PULL_MODE` if needed.
ACK. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11132#pullrequestreview-214493604
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190314/057d7b5e/attachment.html>


More information about the notifications mailing list