[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: check if pkt is NULL on error (#11182)

Martine Lenders notifications at github.com
Thu Mar 14 14:39:24 CET 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
According to the documentation of `gnrc_ipv6_nib_get_next_hop_l2addr()` `pkt` may be `NULL`. However, whenever that function sends an error message (the methods for that require `orig_pkt` not to be NULL) `pkt` is not checked, which may lead to failed assertions.

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Compile and flash `tests/gnrc_ipv6_nib` with `USEMODULE=gnrc_icmpv6_error`

USEMODULE=gnrc_icmpv6_error make flash

and run the test

make test

Without this fix the test will fail on an assertion at


With this fix the tests will pass.

### Issues/PRs references
Discovered while debugging #11068 where I use `gnrc_ipv6_nib_get_next_hop_l2addr()` with `pkt == NULL`


Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * gnrc_ipv6_nib: check if pkt is NULL on error

-- File Changes --

    M sys/net/gnrc/network_layer/ipv6/nib/nib.c (13)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190314/e01e44ed/attachment.html>

More information about the notifications mailing list