[riot-notifications] [RIOT-OS/RIOT] nrf802154: Validate frame length before dst filter (#11191)

Koen Zandberg notifications at github.com
Thu Mar 14 21:26:19 CET 2019


bergzand commented on this pull request.



> @@ -131,6 +131,22 @@ static void _enable_tx(void)
     NRF_RADIO->TASKS_START = 1;
  }
 
+/**
+ * @brief basic ieee802.15.4 data frame validation
+ */
+static bool _data_frame_filter(void)
+{
+    size_t expected_len = ieee802154_get_frame_hdr_len(&rxbuf[1]);

I think the code would end up interpreting the CRC as frame header. So yeah, I would have to add an additional check here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11191#discussion_r265752274
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190314/18ffdd11/attachment.html>


More information about the notifications mailing list