[riot-notifications] [RIOT-OS/RIOT] cpu/esp_common: esp_now doesn't call memcpy if iol_len is 0 (#11187)

Gunar Schorcht notifications at github.com
Fri Mar 15 10:41:06 CET 2019


gschorcht commented on this pull request.



> @@ -652,11 +652,11 @@ static int _send(netdev_t *netdev, const iolist_t *iolist)
                   data_len + iolist->iol_len, ESP_NOW_MAX_SIZE_RAW);

It is guaranteed because this part of the `iol_list` is created and filled by https://github.com/RIOT-OS/RIOT/blob/71204d1d7034b642d310604d0bc9ec4fe634f414/cpu/esp_common/esp-now/esp_now_gnrc.c#L69-L73 as variable on stack before it calls esp_now_netdev::_send with the `iol_list`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11187#discussion_r265908635
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190315/33b4b713/attachment-0001.html>


More information about the notifications mailing list