[riot-notifications] [RIOT-OS/RIOT] cpu/esp_common: esp_now doesn't call memcpy if iol_len is 0 (#11187)

Martine Lenders notifications at github.com
Fri Mar 15 11:16:56 CET 2019

miri64 commented on this pull request.

> @@ -652,11 +652,11 @@ static int _send(netdev_t *netdev, const iolist_t *iolist)
                   data_len + iolist->iol_len, ESP_NOW_MAX_SIZE_RAW);

Though... I just noticed: Having at least a non-zero L2 header should be a requirement for most platforms. Maybe we rather do it the other way around: document that the device *may* need the first header to be of non-zero length, and document the corner cases, where this isn't the case necessarily (e.g. SLIP).

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190315/9c586742/attachment.html>

More information about the notifications mailing list