[riot-notifications] [RIOT-OS/RIOT] shell_commands: include RSSI in ping output (#11092)

Marian Buschsieweke notifications at github.com
Fri Mar 15 13:29:03 CET 2019


I think @SemjonKerner is pointing out that this PR was created at a point in time the nrf driver was not yet included in RIOT's master. Rebasing this PR on top of the current master would allow using it.

I personally have no strong opinion about rebasing. The pro would be that testers would not need to rebase locally and the testing results are theoretically more trustful if the exact state of the PR is tested. The con is that force pushs during PRs would require the reviewers to look at the source code again to rule out some mistakes sneaked in - (this happens more frequently than one would guess and also happened to me).

Btw: Sorry for stalling with the `cc110x` test. As @bergzand referenced this PR to test the RSSI output of nrf802154, I guess the issue with the `cc110x` is unrelated to this PR. Maybe @bergzand can tick the testing label if I'm this did indeed work with another transceiver?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11092#issuecomment-473267371
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190315/dd0370db/attachment.html>


More information about the notifications mailing list