[riot-notifications] [RIOT-OS/RIOT] sam0 flashpage RWWEE flash support [WIP] (#10884)

Dylan Laduranty notifications at github.com
Sun Mar 17 21:41:39 CET 2019


dylad commented on this pull request.



> @@ -366,6 +526,15 @@ static const shell_command_t shell_commands[] = {
     { "test_last", "Write and verify test pattern on last page available", cmd_test_last },
 #ifdef MODULE_PERIPH_FLASHPAGE_RAW
     { "test_last_raw", "Write and verify raw short write on last page available", cmd_test_last_raw },
+#endif
+#ifdef FLASHPAGE_RWWEE_NUMOF
+    { "read_rwwee", "Copy the given page from RWWEE to the local page buffer and dump to STDOUT", cmd_read_rwwee },
+    { "write_rwwee", "Write the local page buffer to the given RWWEE page", cmd_write_rwwee },
+    { "test_rwwee", "Write and verify test pattern to RWWEE", cmd_test_rwwee },
+    { "test_last_rwwee", "Write and verify test pattern on last RWWEE page available", cmd_test_last_rwwee },
+#ifdef MODULE_PERIPH_FLASHPAGE_RAW

Why adding this #ifdef here while you have the very same a few lines above ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10884#pullrequestreview-215373905
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190317/1671bb5c/attachment.html>


More information about the notifications mailing list