[riot-notifications] [RIOT-OS/RIOT] tests/unittests: exclude ENOMEM tests for gnrc_pktbuf_malloc (#11197)

Sebastian Meiling notifications at github.com
Mon Mar 18 08:48:56 CET 2019


smlng requested changes on this pull request.

To me this is (kind of) bad test design, we shouldn't use `#ifdef` here. Because automated tests will not compile this with `_static` and `_malloc`. I think the better solution would be to have a generic `pktbuf` tests that works with both and also have to specific ones to test the differing functionality and behaviour. 

Because in the `Makefile.include` its always `_static` (and RIOT default, too), so problems with malloc will not show up in auto testing - which is bad. Also I saw there are already `#ifdef`s for the `MALLOC` case in here, these should be (re)moved, too.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11197#pullrequestreview-215452226
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190318/f8858f60/attachment-0001.html>


More information about the notifications mailing list