[riot-notifications] [RIOT-OS/RIOT] boards/common/nrf52xxxdk: Fixed periph conf (#11206)

Marian Buschsieweke notifications at github.com
Tue Mar 19 12:11:49 CET 2019


### Contribution description
- Used proper `GPIO_PIN()` macro to declare pins, instead of hard coded values
- On the nRF52840DK use P1.13, P1.14, and P1.15 instead of P0.13, P0.14, and P0.15 to allow using Arduino Shields. (For whatever reason different pins are connected to the "Arduino ICSP header" of the nRF52840DK compared to the nRF52DK. This update handles the difference.)

### Testing procedure

E.g. run `examples/gnrc_networking` with the following patch applied and the W5100 ethernet shield.

```patch
diff --git a/examples/gnrc_networking/Makefile b/examples/gnrc_networking/Makefile
index 78a9eb7f56..29d3ae3da3 100644
--- a/examples/gnrc_networking/Makefile
+++ b/examples/gnrc_networking/Makefile
@@ -19,7 +19,6 @@ BOARD_INSUFFICIENT_MEMORY := arduino-duemilanove arduino-mega2560 arduino-nano \
 
 # Include packages that pull up and auto-init the link layer.
 # NOTE: 6LoWPAN will be included if IEEE802.15.4 devices are present
-USEMODULE += gnrc_netdev_default
 USEMODULE += auto_init_gnrc_netif
 # Activate ICMPv6 error messages
 USEMODULE += gnrc_icmpv6_error
@@ -40,6 +39,7 @@ USEMODULE += ps
 USEMODULE += netstats_l2
 USEMODULE += netstats_ipv6
 USEMODULE += netstats_rpl
+USEMODULE += w5100
 
 # Comment this out to disable code in RIOT that does safety checking
 # which is not needed in a production environment but helps in the
@@ -74,3 +74,7 @@ else
     CFLAGS += -DIEEE802154_DEFAULT_CHANNEL=$(DEFAULT_CHANNEL)
   endif
 endif
+
+CFLAGS += '-DW5100_PARAM_CS=GPIO_PIN(1,12)'
+CFLAGS += '-DW5100_PARAM_EVT=GPIO_PIN(1,3)'
+CFLAGS += '-DDEBUG_ASSERT_VERBOSE'
```

### Issues/PRs references

None
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11206

-- Commit Summary --

  * boards/common/nrf52xxxdk: Fixed periph conf

-- File Changes --

    M boards/common/nrf52xxxdk/include/periph_conf_common.h (25)
    M boards/nrf52840dk/include/periph_conf.h (1)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11206.patch
https://github.com/RIOT-OS/RIOT/pull/11206.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11206
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190319/3a76cef7/attachment.html>


More information about the notifications mailing list