[riot-notifications] [RIOT-OS/RIOT] riotboot: use epoch as APP_VER default (#11180)

Gaëtan Harter notifications at github.com
Tue Mar 19 14:29:01 CET 2019


I found about this while reviewing https://github.com/RIOT-OS/RIOT/pull/11181

This changed is an API change without setting the label and without updating the documentation  https://github.com/RIOT-OS/RIOT/blob/master/bootloaders/riotboot/README.md

The APP_VER changed from being an application version to be the build date. This should have been the result of a proper justification why changing the semantic. It was set to a fixed value by default because it is a version and should be handled as such.

Also the commit message does not justify or explain any of the consequence of this https://github.com/RIOT-OS/RIOT/pull/11180/commits/09a40fb6fcb58a693758318fe8103d4abf7cd866

It changed from being an application version to being the build date, so not even a SOURCE_DATE_EPOCH or something.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11180#issuecomment-474368747
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190319/1277db8c/attachment.html>


More information about the notifications mailing list