[riot-notifications] [RIOT-OS/RIOT] tests/posix_semaphore: sem_timedwait should not return before abstime (#11222)

Juan I Carrano notifications at github.com
Wed Mar 20 16:10:45 CET 2019


jcarrano approved this pull request.

It is probable that some board will "break" when this test is fixed, but then it is not that _breaks_, but rather it was already broken and we did not notice.

> @@ -279,7 +279,7 @@ void test4(void)
     }
 
     uint64_str[fmt_u64_dec(uint64_str, elapsed)] = '\0';
-    if (elapsed < (exp - 100)) {
+    if (elapsed < exp) {

Ok, clearly this was _not_ testing what it was supposed to.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11222#pullrequestreview-216784781
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190320/54deb3f2/attachment.html>


More information about the notifications mailing list