[riot-notifications] [RIOT-OS/RIOT] sam0_common: Add USB peripheral driver (#10915)

Koen Zandberg notifications at github.com
Wed Mar 20 22:31:30 CET 2019


bergzand commented on this pull request.



> +    else {
+        _disable_ep_stall_out(ep_reg);
+        ep_reg->EPSTATUSCLR.reg = USB_DEVICE_EPSTATUSCLR_BK0RDY;
+    }
+    return 0;
+}
+
+/**
+ * Endpoint event handler
+ *
+ * Calls the endpoint callback to report the event to the USB stack
+ */
+static void _usbdev_ep_esr(usbdev_ep_t *ep)
+{
+    UsbDeviceEndpoint *ep_reg = _ep_reg_from_ep(ep);
+    signed event = -1;

But same as [this comment](https://github.com/RIOT-OS/RIOT/pull/11213#discussion_r267553921), there is not really a need for a specific variable size here, so I'd rather give the compiler more freedom for possible optimizations.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10915#discussion_r267555043
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190320/8aaafaab/attachment.html>


More information about the notifications mailing list