[riot-notifications] [RIOT-OS/RIOT] sys/ecc: move hamming256 module to generic ecc (#9988)

Marian Buschsieweke notifications at github.com
Thu Mar 21 20:50:07 CET 2019


maribu commented on this pull request.

@PeterKietzmann: Please see inline comment. I believe I found a bug. If so, could you create the follow up PR, or should I do?

> @@ -811,3 +811,7 @@ USEPKG := $(sort $(USEPKG))
 ifneq ($(OLD_USEMODULE) $(OLD_USEPKG),$(USEMODULE) $(USEPKG))
   include $(RIOTBASE)/Makefile.dep
 endif
+
+ifneq (,$(filter ecc_%,$(USEMODULE)))
+  USEMODULE += ecc
+endif

@PeterKietzmann: Is it by intent that this was put out of the recursive dependency tracking and after the sorting/deduplication of `USEMODULE` entries? This looks like a bug to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9988#pullrequestreview-217456803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190321/8beedc81/attachment.html>


More information about the notifications mailing list