[riot-notifications] [RIOT-OS/RIOT] sys/ecc: move hamming256 module to generic ecc (#9988)

Marian Buschsieweke notifications at github.com
Fri Mar 22 12:16:00 CET 2019


maribu commented on this pull request.



> @@ -811,3 +811,7 @@ USEPKG := $(sort $(USEPKG))
 ifneq ($(OLD_USEMODULE) $(OLD_USEPKG),$(USEMODULE) $(USEPKG))
   include $(RIOTBASE)/Makefile.dep
 endif
+
+ifneq (,$(filter ecc_%,$(USEMODULE)))
+  USEMODULE += ecc
+endif

I was wrong,  duplicates in `USEMODULE` will not always result in build failures. But it will result at least in ugly warnings. E.g. when simply adding `USEMODULE += core_msg` at the bottom of `Makefile.dep` in the current master branch to have it listed twice (`core_msg` is a default module), I get the following output:

```
examples/hello-world $ make
Building application "hello-world" for "nucleo-f303re" with MCU "stm32f3".

"make" -C /home/maribu/Repos/software/RIOT/boards/nucleo-f303re
"make" -C /home/maribu/Repos/software/RIOT/boards/common/nucleo
"make" -C /home/maribu/Repos/software/RIOT/core
/home/maribu/Repos/software/RIOT/Makefile.base:82: target '/home/maribu/Repos/software/RIOT/examples/hello-world/bin/nucleo-f303re/core/msg.o' given more than once in the same rule
/home/maribu/Repos/software/RIOT/Makefile.base:82: target '/home/maribu/Repos/software/RIOT/examples/hello-world/bin/nucleo-f303re/core/msg.o' given more than once in the same rule
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9988#discussion_r268127013
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190322/7139aec8/attachment.html>


More information about the notifications mailing list