[riot-notifications] [RIOT-OS/RIOT] boards: include common dfu logic where applicable (#11192)

Gaƫtan Harter notifications at github.com
Mon Mar 25 10:38:31 CET 2019


Now all boards use `--reset` after, the `pyboard` now adds `:leave` and some boards now have the address given.
If these changes are indeed correct, I would like to have the reason precised.

------

For simplifying the comparison, I locally modified `dfu.inc.mk` to use the short option names. But I indeed prefer having long ones.

List all boards on the pull request:
```
DFU_BOARDS=$(git grep -l -e dfu.inc.mk -e 'common/stm32f103c8/Makefile.include' ':!boards/common' | cut -f 2 -d/)
echo ${DFU_BOARDS}
blackpill bluepill nz32-sc151 pyboard spark-core
```

``` diff
diff -u output_master output_pr 
--- output_master       2019-03-25 10:33:22.279177314 +0100
+++ output_pr   2019-03-25 10:33:31.979214336 +0100
@@ -1,10 +1,10 @@
 blackpill
-true -d 1eaf:0003 -a 2 -D "/home/harter/work/git/RIOT/examples/hello-world/bin/blackpill/hello-world.bin"
+true -d 1eaf:0003 -a 2 -s 0x8002000:leave -D /home/harter/work/git/RIOT/examples/hello-world/bin/blackpill/hello-world.bin --reset
 bluepill
-true -d 1eaf:0003 -a 2 -D "/home/harter/work/git/RIOT/examples/hello-world/bin/bluepill/hello-world.bin"
+true -d 1eaf:0003 -a 2 -s 0x8002000:leave -D /home/harter/work/git/RIOT/examples/hello-world/bin/bluepill/hello-world.bin --reset
 nz32-sc151
-true -d 0483:df11 -a 0 -s 0x08000000:leave -D "/home/harter/work/git/RIOT/examples/hello-world/bin/nz32-sc151/hello-world.bin"
+true -d 0483:df11 -a 0 -s 0x08000000:leave -D /home/harter/work/git/RIOT/examples/hello-world/bin/nz32-sc151/hello-world.bin --reset
 pyboard
-true -D /home/harter/work/git/RIOT/examples/hello-world/bin/pyboard/hello-world.bin --reset --alt 0 -s 0x8000000
+true -d 1d50:607f -a 0 -s 0x08000000:leave -D /home/harter/work/git/RIOT/examples/hello-world/bin/pyboard/hello-world.bin --reset
 spark-core
-true -d 1d50:607f -a 0 -s 0x08005000:leave -D "/home/harter/work/git/RIOT/examples/hello-world/bin/spark-core/hello-world.bin"
+true -d 1d50:607f -a 0 -s 0x8005000:leave -D /home/harter/work/git/RIOT/examples/hello-world/bin/spark-core/hello-world.bin --reset
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11192#issuecomment-476119973
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190325/dc2510b0/attachment.html>


More information about the notifications mailing list