[riot-notifications] [RIOT-OS/RIOT] boards: include common dfu logic where applicable (#11192)

Gaƫtan Harter notifications at github.com
Mon Mar 25 10:53:20 CET 2019


cladmi commented on this pull request.



> @@ -23,14 +23,17 @@ include $(RIOTMAKE)/tools/serial.inc.mk
 # (ground) GPIO B1.
 ifeq ($(PROGRAMMER),dfu-util)
   export ROM_OFFSET ?= 0x2000 # Skip the space needed by the embedded bootloader
-  export FLASHER = dfu-util
-  export DEBUGGER = # no debugger
-  export RESET = # dfu-util has no support for resetting the device
+  # flash the board using DFU
+  # Set ALT to 2
+  DFU_ALT = 2

These one should I think be replaced by `DFU_ALT ?= 2` and same for the `DFU_ID ?= value` in general.
Also here the comment before is quite not necessary in this state.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11192#pullrequestreview-218229515
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190325/cda53f23/attachment.html>


More information about the notifications mailing list