[riot-notifications] [RIOT-OS/RIOT] shell: Add command i2c_scan (#11240)

MrKevinWeiss notifications at github.com
Mon Mar 25 12:36:56 CET 2019


MrKevinWeiss approved this pull request.

I think it is good to go ACK!  Here are the test results:
<details><summary>samr21-xpro</summary>
<p>

```
2019-03-25 10:38:16,637 - INFO #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2019-03-25 10:38:16,645 - INFO # 0x00 R R R R R R R R R R R R R R - -
2019-03-25 10:38:16,653 - INFO # 0x10 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,662 - INFO # 0x20 - - - - - - - - X - - - - - - -
2019-03-25 10:38:16,670 - INFO # 0x30 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,678 - INFO # 0x40 - - X - - - - - - - - - - - - -
2019-03-25 10:38:16,686 - INFO # 0x50 - - - - - X - - - - - - - - - -
2019-03-25 10:38:16,694 - INFO # 0x60 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,702 - INFO # 0x70 - - - - - - - - R R R R R R R R

```
</p>
</details>

<details><summary>nrf52dk</summary>
<p>

```
2019-03-25 10:38:16,640 - INFO #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2019-03-25 10:38:16,649 - INFO # 0x00 R R R R R R R R R R R R R R - -
2019-03-25 10:38:16,658 - INFO # 0x10 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,667 - INFO # 0x20 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,676 - INFO # 0x30 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,685 - INFO # 0x40 - - X - - - - - - - - - - - - -
2019-03-25 10:38:16,694 - INFO # 0x50 - - - - - X - - - - - - - - - -
2019-03-25 10:38:16,703 - INFO # 0x60 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,712 - INFO # 0x70 - - - - - - - - R R R R R R R R
```

</p>
</details>

<details><summary>nucleo-l073rz</summary>
<p>

```
2019-03-25 10:38:16,642 - INFO #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2019-03-25 10:38:16,652 - INFO # 0x00 R R R R R R R R R R R R R R - -
2019-03-25 10:38:16,662 - INFO # 0x10 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,672 - INFO # 0x20 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,681 - INFO # 0x30 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,691 - INFO # 0x40 - - X - - - - - - - - - - - - -
2019-03-25 10:38:16,700 - INFO # 0x50 - - - - - X - - - - - - - - - -
2019-03-25 10:38:16,710 - INFO # 0x60 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,720 - INFO # 0x70 - - - - - - - - R R R R R R R R
```

</p>
</details>

<details><summary>nucleo-f411re</summary>
<p>

```
2019-03-25 10:38:16,642 - INFO #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2019-03-25 10:38:16,680 - INFO # 0x00 R R R R R R R R R R R R R R E E
2019-03-25 10:38:17,116 - INFO # 0x10 E E E E E E E E E E E E E E E E
2019-03-25 10:38:17,561 - INFO # 0x20 E E E E E E E E E E E E E E E E
2019-03-25 10:38:18,000 - INFO # 0x30 E E E E E E E E E E E E E E E E
2019-03-25 10:38:18,441 - INFO # 0x40 E E E E E E E E E E E E E E E E
2019-03-25 10:38:18,882 - INFO # 0x50 E E E E E E E E E E E E E E E E
2019-03-25 10:38:19,322 - INFO # 0x60 E E E E E E E E E E E E E E E E
2019-03-25 10:38:19,543 - INFO # 0x70 E E E E E E E E R R R R R R R R
```

</p>
</details>

<details><summary>remote-revb</summary>
<p>

```
2019-03-25 10:38:16,650 - INFO #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2019-03-25 10:38:16,658 - INFO # 0x00 R R R R R R R R R R R R R R - -
2019-03-25 10:38:16,666 - INFO # 0x10 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,674 - INFO # 0x20 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,682 - INFO # 0x30 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,689 - INFO # 0x40 - - X - - - - - - - - - - - - -
2019-03-25 10:38:16,697 - INFO # 0x50 - - - - - X - - - - - - - - - -
2019-03-25 10:38:16,705 - INFO # 0x60 - - - - - - - - - X - - - - - -
2019-03-25 10:38:16,713 - INFO # 0x70 - - - - - - - - R R R R R R R R
```

</p>
</details>

<details><summary>arduino-mega2560</summary>
<p>

```
2019-03-25 10:38:16,761 - INFO #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2019-03-25 10:38:16,799 - INFO # 0x00 R R R R R R R R R R R R R R - -
2019-03-25 10:38:16,836 - INFO # 0x10 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,877 - INFO # 0x20 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,913 - INFO # 0x30 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,954 - INFO # 0x40 - - X - - - - - - - - - - - - -
2019-03-25 10:38:16,992 - INFO # 0x50 - - - - - X - - - - - - - - - -
2019-03-25 10:38:17,028 - INFO # 0x60 - - - - - - - - - - - - - - - -
2019-03-25 10:38:17,069 - INFO # 0x70 - - - - - - - - R R R R R R R R
```

</p>
</details>

<details><summary>nucleo-f103rb</summary>
<p>

```
2019-03-25 10:38:16,713 - INFO # 0x00 R R R R R R R R R R R R R R E E
2019-03-25 10:38:17,415 - INFO # 0x10 E E E E E E E E E E E E E E E E
2019-03-25 10:38:18,117 - INFO # 0x20 E E E E E E E E E E E E E E E E
2019-03-25 10:38:18,820 - INFO # 0x30 E E E E E E E E E E E E E E E E
2019-03-25 10:38:19,522 - INFO # 0x40 E E E E E E E E E E E E E E E E
2019-03-25 10:38:20,225 - INFO # 0x50 E E E E E E E E E E E E E E E E
2019-03-25 10:38:20,927 - INFO # 0x60 E E E E E E E E E E E E E E E E
2019-03-25 10:38:21,280 - INFO # 0x70 E E E E E E E E R R R R R R R R
```

</p>
</details>

<details><summary>frdm-k22f</summary>
<p>

```
2019-03-25 10:38:16,644 - INFO # 0x00 R R R R R R R R R R R R R R - -
2019-03-25 10:38:16,652 - INFO # 0x10 - - - - - - - - - - - - X - - -
2019-03-25 10:38:16,660 - INFO # 0x20 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,668 - INFO # 0x30 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,677 - INFO # 0x40 - - X - - - - - - - - - - - - -
2019-03-25 10:38:16,685 - INFO # 0x50 - - - - - X - - - - - - - - - -
2019-03-25 10:38:16,693 - INFO # 0x60 - - - - - - - - - - - - - - - -
2019-03-25 10:38:16,702 - INFO # 0x70 - - - - - - - - R R R R R R R R
```

</p>
</details>

The function works OK, it even pointed out a problem with the tests and implementation of i2c2.c in the cpu/stm32_common.  Multi nacks have not been tested which is why on the nucleo-f103 and nucleo-f411 are erroring.  Fix is in #11259





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11240#pullrequestreview-218276522
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190325/848ee5fb/attachment-0001.html>


More information about the notifications mailing list