[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: add the new API function uart_mode to periph/uart (#11231)

MrKevinWeiss notifications at github.com
Mon Mar 25 13:41:00 CET 2019


MrKevinWeiss commented on this pull request.

Would you be willing to split the PRs into a cleanup `__uart -> _uart` and the mode functionality?

I can do some testing at the end of the week.

>  {
     DEBUG("%s uart=%d, rate=%d\n", __func__, uart, baudrate);
 
     CHECK_PARAM_RET (uart < UART_NUMOF, -1);
 
+    /* wait until TX FIFI is empty */
+    while (_uarts[uart].regs->status.txfifo_cnt != 0) { }
+
+    critical_enter();

Can you put some information on why you added the critical*, does it apply to the *_mode or is it something separate

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11231#pullrequestreview-218300785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190325/19680268/attachment.html>


More information about the notifications mailing list