[riot-notifications] [RIOT-OS/RIOT] can: fix a race condition with tx_list (#11262)

Vincent Dupont notifications at github.com
Mon Mar 25 16:38:07 CET 2019


### Contribution description

This PR fixes a race condition with tx_list (linked list of packet that are being sent) between abort and tx confirmation. It could lead to the list being corrupted, thus a crash.

The last commit improves the conn layer to not used message blocking functions from an interrupt.

### Testing procedure

Tested in debug

### Issues/PRs references

based on #9404

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11262

-- Commit Summary --

  * can: use memarray for pkt and router allocation
  * tests/conn_can: reduce size of pkt buffers
  * can: fix race condition in tx_list
  * can/conn: use non-blocking function from timer interupts

-- File Changes --

    M Makefile.dep (3)
    M sys/can/conn/isotp.c (26)
    M sys/can/conn/raw.c (4)
    M sys/can/dll.c (85)
    M sys/can/pkt.c (83)
    M sys/can/router.c (27)
    M sys/include/can/common.h (3)
    M sys/include/can/pkt.h (5)
    M sys/include/can/router.h (7)
    M tests/conn_can/Makefile (6)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11262.patch
https://github.com/RIOT-OS/RIOT/pull/11262.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11262
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190325/76ac96f0/attachment-0001.html>


More information about the notifications mailing list