[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: add the new API function uart_mode to periph/uart (#11231)

Gunar Schorcht notifications at github.com
Mon Mar 25 17:29:09 CET 2019


@MrKevinWeiss Thank you for reviewing the PR.

> Would you be willing to split the PRs into a cleanup __uart -> _uart and the mode functionality?

Hm, ... It is only a very small naming fix to get the code compatible with the reimplementation of ESP8266 in PR #11108 which will allow code deduplication with future PRs.

Sure, I could provide a separate PR, but I didn't want to open too many different development branches which later cause a lot of merging conflicts or too many dependencies of different PRs. But, if you think that it might be better to have different PRs, I would provide a separate PR for renaming and would make the this PR dependent on the separate PR. BTW, PR #10644 requires changed names too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11231#issuecomment-476275681
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190325/ce7fc728/attachment-0001.html>


More information about the notifications mailing list