[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: add packet to queue when device is busy (#11263)

Martine Lenders notifications at github.com
Tue Mar 26 10:05:40 CET 2019


miri64 commented on this pull request.



> @@ -1411,21 +1441,27 @@ static void _event_cb(netdev_t *dev, netdev_event_t event)
         gnrc_pktsnip_t *pkt = NULL;
         switch (event) {
             case NETDEV_EVENT_RX_COMPLETE:
+                _send_queued_pkt(netif);

> The other problem would be that this basically requires the network device to keep the just received packet "on hold", send a queued packet, and only then get the held packet out of the device. I don't think all devices allow that.

Oh damn, you are right, this needs to be called after the receive.

> I'm not sure, this might be solved by getting the received packet first, then initiating the send. E.g., swap 1444 and 1445. A downside would be that both packets need to be in memory at the same time, but I suspect that otherwise, the device needs to provide extra buffering...

Yepp. Rather put it in the stack's buffer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11263#discussion_r268998993
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/d351174c/attachment.html>


More information about the notifications mailing list