[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: add packet to queue when device is busy (#11263)

Martine Lenders notifications at github.com
Tue Mar 26 10:08:31 CET 2019


miri64 commented on this pull request.



> @@ -1411,21 +1441,27 @@ static void _event_cb(netdev_t *dev, netdev_event_t event)
         gnrc_pktsnip_t *pkt = NULL;
         switch (event) {
             case NETDEV_EVENT_RX_COMPLETE:
+                _send_queued_pkt(netif);

> For one, it is completely surprising to see this here, without the context of why this PR exists in the first place.

How can I alleviate this surprise? Would some comment help?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11263#discussion_r269000113
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/53c54b6b/attachment.html>


More information about the notifications mailing list