[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: add packet to queue when device is busy (#11263)

Kaspar Schleiser notifications at github.com
Tue Mar 26 10:15:11 CET 2019


kaspar030 commented on this pull request.



> @@ -1411,21 +1441,27 @@ static void _event_cb(netdev_t *dev, netdev_event_t event)
         gnrc_pktsnip_t *pkt = NULL;
         switch (event) {
             case NETDEV_EVENT_RX_COMPLETE:
+                _send_queued_pkt(netif);

I guess so. IMO we need some documentation to point to that explains why the netif thread cannot block when it gets a send request (or why it cannot block at all actually).

For now a comment is probably sufficient. Something that refers to where the packets get queued.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11263#discussion_r269002466
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/f4c890d5/attachment.html>


More information about the notifications mailing list