[riot-notifications] [RIOT-OS/RIOT] riotboot_flashwrite: Failure on the nrf52 (#11274)
notifications at github.com
Tue Mar 26 10:22:40 CET 2019
Having slots starting on full pages is a requirement and should be at least documented.
Asking them to have a length of full pages is also I think a better thing to do, otherwise, the remaining space is lost, so it is sane enough to require "full pages".
A check could be even done at compile time in the bootloader/and modules using "slots" if we require it to have the "FLASHPAGE_SIZE" information available for them.
However having a bootloader being a multiple of two is currently not a requirement, there could be cases where you have a 1 page bootloader, and some ROM reserved at the end taking 3 pages so have even number of pages in the middle.
So I would prefer to have the test check only what is required, even if our solution to handle this is currently doing "2 pages bootloader"
The issue comes from the calculation of SLOT_LEN that does not have any information of a cpu page size and so need to assume that ROM_LEN - RIOTBOOT_LEN is a multiple of 2 pages.
I am not sure having the "page size" information in the build system is needed or even wanted.
And a solution doing "lets give 2 pages to the bootloader" is for me good enough.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications