[riot-notifications] [RIOT-OS/RIOT] boot: Moved stdio_init() into periph_init() (#10806)

Hauke Petersen notifications at github.com
Tue Mar 26 10:47:13 CET 2019


haukepetersen requested changes on this pull request.

Sorry for only jumping in so late, but I have to object on the concept this PR solves the problem at hand. See me inline comment for a IMHO better solution to this.

>  void periph_init(void)
 {
+    /* initialize stdio first to allow DEBUG() during later stages */
+#ifdef CPU_NATIVE

This 'ifdef' hell should not be here. After all, `periph_common` is a platform independent module and adding all this platform dependencies here does destroy this whole concept!

The better way I see is to move these calls to the common platform modules, calling these functions from right before `periph_init` is called (or not in e.g. case of native). This way there is no need for any hard to read ifdefs anywhere, just a `#ifdef MODULE_STDIO` in for each supported architecture...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10806#pullrequestreview-218782150
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/6f013110/attachment.html>


More information about the notifications mailing list