[riot-notifications] [RIOT-OS/RIOT] stm32_common/i2c_2: fix unused *i2c when no DEVELHELP (#11279)
notifications at github.com
Tue Mar 26 13:12:14 CET 2019
MrKevinWeiss requested changes on this pull request.
Very nice catch, this also points out a much bigger problem of not CI testing with the different settings (DEVELHELP=0).
> I2C_TypeDef *i2c = i2c_config[dev].dev;
assert(i2c != NULL);
I think if we can avoid ifdefs that would be nice,
would you consider just doing
assert(i2c_config[dev].dev != NULL);
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications