[riot-notifications] [RIOT-OS/RIOT] boot: Moved stdio_init() into periph_init() (#10806)

Marian Buschsieweke notifications at github.com
Tue Mar 26 17:48:47 CET 2019


Honestly, I'm not fully sure if a panic on `DEBUG()` before stdio is available is better than not having any indication that something went wrong. `DEBUG()` is not supposed to happen in production code. And a developer that added `DEBUG()` to some code and gets no output might have to look at a lot of things before tracing the issue down to not having `stdio` available.

But more generally: @MrKevinWeiss already implemented a safeguard in https://github.com/RIOT-OS/RIOT/pull/10615 that drops UART output when used prior to initialization. But that change affects `DEBUG()` and production code alike and could potentially result in `DEBUG()` output getting lost. This PR is intended to be a kind-of follow up to make sure that this never happens.

> Personally, I think this is overkill

Let me point out again that the test I suggested to add to `periph_init()` for automated testing is not supposed to be compiled in by default (as that is only useful for automated testing). It could be as simple as:

```C
#ifdef TEST_STDIO_OUTPUT_ON_PERIPH_INIT
    puts("Initializing peripheral devices...");
#endif
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10806#issuecomment-476741637
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/d276b643/attachment-0001.html>


More information about the notifications mailing list