[riot-notifications] [RIOT-OS/RIOT] cpu/esp: treat undefined reference as errors (#11246)
notifications at github.com
Tue Mar 26 19:18:55 CET 2019
@cladmi This changes are only for fixing the undefined reference to `pthread_setcancelstate`.
The problem with `pthread_setcancelstate` was a bit weird. Usually, it was undefined when module `pthread` was not enabled, so that I provided a dummy function `pthread_setcancelstate` defined in `cpu/esp32/syscalls.c` in that case. But sometimes it was also undefined although module `pthread` was enabled. Therefore, I provided the dummy function in any case. However, if `pthread` modules was enabled, I got in some cases multiple defines.
The reason seemed to be that the system libraries were not in the same linker group as the other modules. However, placing them in the same linker group required to override some system functions defined in `newlibc` if module `esp_idf_heap` is enabled.
Finally, I would claim that it is not a fix of an undefined symbol but a fix of the make system (only for ESP32 at the moment). IMO, it should be part of this PR.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications