[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_sock_dns: port to scapy (#10898)

MrKevinWeiss notifications at github.com
Tue Mar 26 19:45:15 CET 2019

MrKevinWeiss commented on this pull request.

I looked at the changes.  I really like the moving to shell tests and implementing logic in python.  The fact that @aabadie comments regarding sudo have been addressed means it doesn't cost anything.

Though I am not a networking guy I was able to run the tests and they seem much more in depth than the test that is replaced.

I would be ok to move this forward if nobody else... @kaspar030... has an opinion as it appears to be an improvement to me.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/7240957d/attachment.html>

More information about the notifications mailing list