[riot-notifications] [RIOT-OS/RIOT] isrpipe: split isrpipe_read_timeout to isolate xtimer dependency (#11267)

Martine Lenders notifications at github.com
Tue Mar 26 19:49:16 CET 2019


miri64 requested changes on this pull request.

Except for the module doc I'm fine. The code and documentation of the functions was just copy-pasted.

> @@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2016 Kaspar Schleiser <kaspar at schleiser.de>
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @defgroup isr_pipe ISR Pipe

This is just copy-pasted from `isrpipe`. You have two options here either remove the `@defgroup` and `@brief` tag and just do `@ingroup isr_pipe` or (since you did not explicitly document that a separate module is needed, I would prefer that)

```C
/**
 * @defgroup isr_pipe_read_timeout  Read timeouts with ISR pipe
 * @ingroup  isr_pipe
 * @brief  ISR -> userspace pipe with timeout
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11267#pullrequestreview-219092991
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/a9fb59dc/attachment.html>


More information about the notifications mailing list