[riot-notifications] [RIOT-OS/RIOT] Makefiles: Sorted & deduplicated rules in `Makefile dep` (#11238)
notifications at github.com
Tue Mar 26 19:56:46 CET 2019
One big issue with changing the "ifeq" rules order is that they do not handle dependencies but rather "policy" to select a default implementation. And this is really really hard to debug without checking in details.
And the murdock output shows issues with the `lwip` ordering that breaks something.
I already had the issue in the lwip when refactoring inside the packages https://github.com/RIOT-OS/RIOT/pull/9307/commits/1be18e9dd5cf43f51fb1dfbbcc0c2655474ee919
It is something I want to address but would rather first group all the dependencies to only one step (instead of having some dependency handled in `boards/Makefile.include`) as I describe in followed by https://github.com/RIOT-OS/RIOT/issues/9913
This way, it would be way easier to process many many different configurations as it would not need to call gcc in the middle to get its supported options and getting the output to ensure there is no regression. Otherwise it needs analyzing precisely each change.
However the de-duplication should be good to do as it is easier to review.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications