[riot-notifications] [RIOT-OS/RIOT] gnrc: fix several issues found with LLVM's static code analyzer (#10350)

Gaƫtan Harter notifications at github.com
Tue Mar 26 20:55:52 CET 2019


cladmi commented on this pull request.

The changes looks good, but it looks like the one for the command line handling could be changing the output. Is there a way to test this ?

> @@ -379,19 +378,16 @@ static void _netif_list_ipv6(ipv6_addr_t *addr, uint8_t flags)
                 break;
         }
     }
-    line_thresh = _newline(0U, line_thresh);
+    puts("");

These seems they would change the output, as the previous version looks like its printing `\n (many spaces) `.
Not sure if it is wanted to replace it with only `\n`.

>      if ((ipv6_addr_is_multicast(addr))) {
         char addr_str[IPV6_ADDR_MAX_STR_LEN];
         ipv6_addr_to_str(addr_str, addr, sizeof(addr_str));
-        printf("inet6 group: %s", addr_str);
+        printf("inet6 group: %s\n", addr_str);

This changes from always printing  `\n (many spaces) ` to sometime only printing a new line.
Not sure if it is wanted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10350#pullrequestreview-219124544
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/13d1b886/attachment.html>


More information about the notifications mailing list