[riot-notifications] [RIOT-OS/RIOT] l2util: initial import of a general IPv6 over X helper module (#10589)

Hauke Petersen notifications at github.com
Tue Mar 26 21:13:14 CET 2019


haukepetersen requested changes on this pull request.

minor findings in doc, please clarify :-)

> + *
+ * @pre @p iid was based on a hardware address
+ * @pre The number of bytes available at @p addr is less or equal to
+ *      @ref L2UTIL_ADDR_MAX_LEN.
+ *
+ * @attention   When `NDEBUG` is not defined, the node fails with an assertion
+ *              instead of returning `-ENOTSUP`
+ *
+ * @param[in] dev_type  The network device type of the device the @p iid came
+ *                      from (either because it is based on the configured
+ *                      address of the device or from a packet that came over
+ *                      it).
+ * @param[in] iid       An IID based on @p dev_type.
+ * @param[out] addr     The hardware address. It is assumed that @p iid was
+ *                      based on a hardware address and that the available bytes
+ *                      in @p addr are less or equal to

greater or equal? Or `must be able to hold the expected link layer address length`?

> + *                      address of the device or from a packet that came over
+ *                      it).
+ * @param[in] iid       An IID based on @p dev_type.
+ * @param[out] addr     The hardware address. It is assumed that @p iid was
+ *                      based on a hardware address and that the available bytes
+ *                      in @p addr are less or equal to
+ *                      @ref L2UTIL_ADDR_MAX_LEN.
+ *
+ * @return  Length of resulting @p addr on success.
+ * @return  `-ENOTSUP`, when @p dev_type does not support reverse IID
+ *          conversion.
+ */
+int l2util_ipv6_iid_to_addr(int dev_type, const eui64_t *iid, uint8_t *addr);
+
+/**
+ * @brief   Derives the length link-layer address in an NDP link-layer address

Derives the length **of** the link layer address?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10589#pullrequestreview-219126792
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/8d6b7b53/attachment.html>


More information about the notifications mailing list