[riot-notifications] [RIOT-OS/RIOT] gnrc: fix several issues found with LLVM's static code analyzer (#10350)

Martine Lenders notifications at github.com
Tue Mar 26 21:16:46 CET 2019


miri64 commented on this pull request.



>      if ((ipv6_addr_is_multicast(addr))) {
         char addr_str[IPV6_ADDR_MAX_STR_LEN];
         ipv6_addr_to_str(addr_str, addr, sizeof(addr_str));
-        printf("inet6 group: %s", addr_str);
+        printf("inet6 group: %s\n", addr_str);

Well the line is always too long and int should be broken after one group in any case.

> @@ -379,19 +378,16 @@ static void _netif_list_ipv6(ipv6_addr_t *addr, uint8_t flags)
                 break;
         }
     }
-    line_thresh = _newline(0U, line_thresh);
+    puts("");

Same goes here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10350#discussion_r269295473
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190326/2102b89a/attachment-0001.html>


More information about the notifications mailing list