[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of DAC channels in board definitions (#11290)
notifications at github.com
Wed Mar 27 09:20:37 CET 2019
### Contribution description
This PR changes the approach of peripheral configurations for DAC channels in board definitions to the usual RIOT approach. With these changes, peripheral configurations use static const arrays in the `boards/esp32*/periph_conf.h` files and define the `*_NUMOF` macros using the size of these static array.
The static configuration arrays contain only definitions that can be changed by the board definition or the application. They do not contain any MCU implementation detail. The board definitions use preprocessor defines as before to fill these static configuration arrays. This makes it possible to override all configurations either with the make command or application specific configuration files.
Please note that commit https://github.com/RIOT-OS/RIOT/commit/8b48dfd62b9ef74dcf3bf023d2fe30fefe76dee3 is in also in related PRs to get each PR compilable separately.
### Testing procedure
Compilation and test with the most common ESP32 board should be executed
make BOARD=esp32-wroom-32 -C tests/periph_dac flash test
### Issues/PRs references
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* cpu/esp32: GPIO defs required for periph conf
* cpu/esp32: DAC config approach changed
* boards/esp32: DAC config approach changed
-- File Changes --
M boards/common/esp32/include/periph_conf_common.h (7)
M boards/esp32-olimex-evb/Makefile.features (2)
M cpu/esp32/include/periph_cpu.h (114)
M cpu/esp32/periph/adc.c (13)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications