[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of ADC channels in board definitions (#11289)

Leandro Lanzieri notifications at github.com
Wed Mar 27 10:58:32 CET 2019


leandrolanzieri requested changes on this pull request.

Just two comments, otherwise looks good to me.

> @@ -149,14 +149,6 @@ const gpio_t _gpio_rtcio_map[] = {
     RTCIO_SENSOR_SENSE4, /* GPIO39 SENSOR_VN */
 };
 
-/** Map of RIOT ADC and DAC lines to GPIOs */
-static const uint32_t adc_pins[] = ADC_GPIOS;
-static const uint32_t dac_pins[] = DAC_GPIOS;

I think that the DAC pins removal belongs to #11290, otherwise compile error arise. 

> @@ -167,6 +159,8 @@ static bool _adc2_ctrl_initialized = false;
 #endif /* defined(ADC_GPIOS) || defined(DAC_GPIOS) */
 
 #if defined(ADC_GPIOS)
+static const unsigned adc_chn_num = ADC_NUMOF;

If we now have the macro, why define `adc_chn_num`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11289#pullrequestreview-219352606
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190327/8c6dc1c2/attachment-0001.html>


More information about the notifications mailing list