[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of DAC channels in board definitions (#11290)

Leandro Lanzieri notifications at github.com
Wed Mar 27 11:35:51 CET 2019


leandrolanzieri commented on this pull request.



> @@ -397,6 +397,7 @@ static void _adc_module_init(void)
 
 #if defined(DAC_GPIOS)
 
+static const unsigned dac_chn_num = DAC_NUMOF;

`dac_chn_num` is being define two times, also, couldn't `DAC_NUMOF` be used instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11290#pullrequestreview-219379342
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190327/f0869c9a/attachment.html>


More information about the notifications mailing list