[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of I2C in board definitions (#11291)

MrKevinWeiss notifications at github.com
Thu Mar 28 14:40:59 CET 2019


MrKevinWeiss approved this pull request.

I would say it looks good.  I also tested it and it appears to work (just manually against PHiLIP).  There are wrong error codes but that isn't related to this PR and I will soon add a test to expose that so don't worry about it now.  I will ACK.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11291#pullrequestreview-220024675
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190328/1ed0b96f/attachment.html>


More information about the notifications mailing list