[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: add the new API function uart_mode to periph/uart (#11231)

Gunar Schorcht notifications at github.com
Thu Mar 28 14:41:08 CET 2019


> > What exactly is the issue? It worked for me.
> 
> No difference between 1 stop bit and 2 stop bits, it appears that the second stop bit is not being sent (always just one stop bit). Also in the code it appears you are assigning the same thing if you set stop bits to 1 or 2.
> 
> ```c
> case UART_STOP_BITS_1:
>     _uarts[uart].regs->conf0.stop_bit_num = 1;
>     _uarts[uart].regs->rs485_conf.dl1_en = 1;
>     break;
> case UART_STOP_BITS_2:
>     _uarts[uart].regs->conf0.stop_bit_num = 1;
>     _uarts[uart].regs->rs485_conf.dl1_en = 1;
>     break;
> ```

Ups, oh yeah. It should be
```c
case UART_STOP_BITS_1:
    _uarts[uart].regs->conf0.stop_bit_num = 1;
    _uarts[uart].regs->rs485_conf.dl1_en = 0;
    break;
```

This happened propably when I changed it back from trying to remove the hack due to the hardware bug. I thought that it is not necessary to test it again since it worked before :sunglasses: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11231#issuecomment-477599295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190328/cf5e0203/attachment.html>


More information about the notifications mailing list